Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change proxmox ve image output format to raw from qcow2 #1636

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

change proxmox ve image output format to raw from qcow2 #1636

wants to merge 1 commit into from

Conversation

stenwt
Copy link

@stenwt stenwt commented Nov 26, 2024 •
edited
Loading

Change description

Changes proxmox image output format from qcow2, which proxmox does not accept, to raw, which it does

Related issues

Additional context

log output after change:

proxmox-iso.ubuntu-2404: output will be in this color.

==> proxmox-iso.ubuntu-2404: Retrieving ISO
==> proxmox-iso.ubuntu-2404: Trying https://releases.ubuntu.com/noble/ubuntu-24.04.1-live-server-amd64.iso
==> proxmox-iso.ubuntu-2404: Trying https://releases.ubuntu.com/noble/ubuntu-24.04.1-live-server-amd64.iso?checksum=sha256%3Ae240e4b801f7bb68c20d1356b60968ad0c33a41d00d828e74ceb3364a0317be9
==> proxmox-iso.ubuntu-2404: https://releases.ubuntu.com/noble/ubuntu-24.04.1-live-server-amd64.iso?checksum=sha256%3Ae240e4b801f7bb68c20d1356b60968ad0c33a41d00d828e74ceb3364a0317be9 => /home/sten/.cache/packer/85d1bf86e5e0ecdd6e91515a63cc10bdab146dca.iso
==> proxmox-iso.ubuntu-2404: Creating VM
==> proxmox-iso.ubuntu-2404: No VM ID given, getting next free from Proxmox
==> proxmox-iso.ubuntu-2404: Starting VM
==> proxmox-iso.ubuntu-2404: Starting HTTP server on port 8149
==> proxmox-iso.ubuntu-2404: Waiting 10s for boot

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 26, 2024 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 26, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @stenwt!

It looks like this is your first PR to kubernetes-sigs/image-builder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/image-builder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @stenwt. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mboersma for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 26, 2024
@mboersma
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 26, 2024
@AverageMarcus
Copy link
Member

@mcbenjemaa as you introduced the format initially are you able to comment on this? I'm not sure which is correct but I know the Proxmox builds have been previously working so curious as to why this PR is needed now.

@mcbenjemaa
Copy link
Member

@mcbenjemaa as you introduced the format initially are you able to comment on this? I'm not sure which is correct but I know the Proxmox builds have been previously working so curious as to why this PR is needed now.

On the contrary, the format qcow2 is fine and works with Proxmox VE.
Perhaps, there’s something different in your setup.
therefore, I advise to add a variable for the disk format.

Format qcow2 makes more sense, and is a bit faster when cloning images. When we provision clusters with CAPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AverageMarcus AverageMarcus Awaiting requested review from AverageMarcus

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proxmox ve builds qcow2 images, which aren't compatible with proxmox
5 participants
@stenwt @k8s-ci-robot @mboersma @AverageMarcus @mcbenjemaa